Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended UsmNDArray creation C-API #1067

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Extended UsmNDArray creation C-API #1067

merged 1 commit into from
Feb 8, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Feb 8, 2023 •
edited
Loading

  • Renamed C-API:
    UsmNDArray_MakeFromMemory -> UsmNDArray_MakeSimpleFromMemory
    UsmNDArray_MakeFromPtr -> UsmNDArray_MakeSimpleFromPtr

  • Added C-API:
    UsmNDArray_MakeFromPtr to create strided array.

  • Added pyx-capi test for the new C-API.

  • Exposed C-API via dpctl_capi.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

@oleksandr-pavlyk
Extended UsmNDArray creation C-API
c0feeef 
Renamed
   `UsmNDArray_MakeFromMemory` -> `UsmNDArray_MakeSimpleFromMemory`
   `UsmNDArray_MakeFromPtr` -> `UsmNDArray_MakeSimpleFromPtr`

Added
   `UsmNDArray_MakeFromPtr` to create strided array.

Added pyx-capi test for the new C-API. Exposed C-API via dpctl_capi.
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1067/index.html

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 82.269% (+0.01%) from 82.257% when pulling c0feeef on feature/usm-ndarray-ctor-capi into 6308866 on master.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_90 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 4028c85 into master Feb 8, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the feature/usm-ndarray-ctor-capi branch February 8, 2023 23:28
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_90 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls