Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double type support check condition for test_print_repr #1070

Merged

Conversation

vlad-perevezentsev
Copy link
Collaborator

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

This PR solves the issue #1069.
The PR adds the has_aspect_fp64 condition in the test_usm_ndarray_print.py::TestPrintFns::test_print_rep to check for double type support on devices and allows that this test passes on Iris Xe.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 82.269%. Remained the same when pulling 04edcc9 on vlad-perevezentsev:fix_test_print_repr into b10be36 on IntelPython:master.

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev ! Somehow I was never running this test file as it was added after I wrote my test driver and did not get to updating it until now.

@oleksandr-pavlyk
Copy link
Collaborator

Generate documentation is known to fail to push to gh-pages branch of the original repo.

@oleksandr-pavlyk oleksandr-pavlyk merged commit b1ee6d1 into IntelPython:master Feb 10, 2023
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_4 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@vlad-perevezentsev vlad-perevezentsev deleted the fix_test_print_repr branch June 20, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_usm_ndarray_print has 1 test failed on Iris XE
3 participants