Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to dpctl-post-link prior changes gh-1081 #1084

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR addresses some shortcomings introduced in gh-1081

conda prunes empty folders, so the dpctl tar-ball did not contain empty etc/OpenCL/vendors folder. Solved by create a dummy .dpctl_readme file in that folder.

The script dpctl-post-link.sh contained a type in the filename it was checking should not exist.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

conda prunes empty folders, so the dpctl tar-ball did not contain
empty etc/OpenCL/vendors folder. Solved by create a dummy `.dpctl_readme`
file in that folder.

The script dpctl-post-link.sh contained a type in the filename it was checking
should not exist.
@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Feb 23, 2023

Coverage Status

Coverage: 82.316%. Remained the same when pulling 0967621 on post-link-post-fix into 79fbb79 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_43 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_44 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 3247a80 into master Feb 23, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the post-link-post-fix branch February 23, 2023 19:21
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_44 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants