Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added get_strides_vector and get_shape_vector #1090

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Added get_strides_vector and get_shape_vector #1090

merged 3 commits into from
Mar 1, 2023

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Mar 1, 2023 •
edited by oleksandr-pavlyk
Loading

This pull request adds methods get_strides_vector and get_shape_vector to usm_ndarray.

These functions are slightly more convenient and can be used to clean up some strides logic, especially where multiple stride copies are involved.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1090/index.html

@coveralls
Copy link
Collaborator

coveralls commented Mar 1, 2023 •
edited
Loading

Coverage Status

Coverage: 82.316%. Remained the same when pulling 7082912 on usm-ndarray-shape-stride-vectors into c32423c on master.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_57 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@ndgrigorian ndgrigorian force-pushed the usm-ndarray-shape-stride-vectors branch from 24b8bdd to df6114d Compare March 1, 2023 02:01
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_57 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk
Copy link
Collaborator

Could you please also remove uses of this->method_name() through the implementation of usm_ndarray?

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_58 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk
Apply suggestions from code review
7082912 
Removed const qualifier from returned vector.
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_59 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@ndgrigorian ndgrigorian merged commit b45e174 into master Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_59 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@ndgrigorian ndgrigorian deleted the usm-ndarray-shape-stride-vectors branch March 2, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk