Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed trailing slash in directory path #1093

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Removed trailing slash in directory path #1093

merged 1 commit into from
Mar 2, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Removed trailing slash in the directory name to avoid double slash in the absolute path of the ICD file.

Related: SAT-5617

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1093/index.html

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 82.316%. Remained the same when pulling 829fb5d on minor-tweaks-to-post-link-pre-unlink into b45e174 on master.

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_61 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

antonwolfy
antonwolfy approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works fine. LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit bc78431 into master Mar 2, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the minor-tweaks-to-post-link-pre-unlink branch March 2, 2023 20:12
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_63 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @antonwolfy