Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean indexing: extract, place, nonzero #1097

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR adds implementation of kernels for boolean indexing.

It adds mask_positions, _extract, _place and _nonzero functions that become
a foundation for forthcoming implementations of dpt.place, dpt.extract
and dpt.nonzero.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Implemented mask_positions, _extract, _place, _nonzero and _array_overlap
APIs.
@oleksandr-pavlyk oleksandr-pavlyk changed the title Boolean indexing: extract, place,nonzero Boolean indexing: extract, place, nonzero Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_115 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_116 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 81.76% (-0.6%) from 82.316% when pulling ed279d6 on boolean-indexing-extract-place-nonzero into bc78431 on master.

This allows to implement behavior of place which cycles over
values of val array if that is shorter than the number of non-zero
elements in the mask.
@oleksandr-pavlyk oleksandr-pavlyk changed the base branch from master to feature/advanced-indexing March 3, 2023 20:06
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_119 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review March 3, 2023 22:36
@oleksandr-pavlyk oleksandr-pavlyk merged commit 9b94ea0 into feature/advanced-indexing Mar 3, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the boolean-indexing-extract-place-nonzero branch March 3, 2023 22:38
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants