Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples clean-up #1108

Merged
merged 14 commits into from
Mar 13, 2023
Merged

Examples clean-up #1108

merged 14 commits into from
Mar 13, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Mar 11, 2023 •
edited
Loading

Modified dpctl/README.md to correct factual inaccuracies.

Provided dpctl/examples/README.md, and read-me files to sub-folders.
Revised all cython examples to follow similar layout and building method, and provided test/ folder for each cython test.

Also modified conda-package.yaml workflow that runs and tests examples to reflect changes made in this PR.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@oleksandr-pavlyk
Replaced use of 'dpcpp' with 'icpx -fsycl'
7fd4475
@oleksandr-pavlyk
Improved examples/cython/sycl_buffer
b1ca555
@oleksandr-pavlyk
Added dynamic work-group size computation to sycl_buffer example
34f8113
@oleksandr-pavlyk
Deleted sycl_direct_linkage since construction of queue per call is a…
9e1806c 
…lready supported

It is support in sycl_buffer example with `queue=None`.

Reworked `usm_memory` example to use `dpctl.tensor.usm_memory` instead of
numpy.ndarray backed up by dpctl.memory.MemoryUSMShared.
@oleksandr-pavlyk
Cleaned up root README.md file
5bc3c4d
@oleksandr-pavlyk
Fixed includes in C example
22d59d7
@oleksandr-pavlyk
Added examples/README.md, and more readme files to sub-directories
27715a0 
Also added `dpctl/tensor/__init__.pxd` so that one can do `cimport dpctl.tensor`.
Used that in `cython/usm_memory` example.
@oleksandr-pavlyk
Updated .flake8 to update new locations in exception list
fd1a9be
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1108/index.html

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_13 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2023 •
edited
Loading

Coverage Status

Coverage: 82.404% (+0.001%) from 82.403% when pulling cc63bba on doc-cleanup-pass into 5bfc097 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_14 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_15 ran successfully.
Passed: 35
Failed: 799
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_16 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_17 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_18 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review March 12, 2023 13:49
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_19 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_23 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 51863d4 into master Mar 13, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the doc-cleanup-pass branch March 13, 2023 13:53
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_28 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls