Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sdl flags #1109

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Add sdl flags #1109

merged 4 commits into from
Mar 13, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Make sure that -fwrapv is used on Linux, and /GS /DynamicBase is used on Windows.

script/build_locally.py now has --verbose mode to invoke cmake with -DCMAKE_MAKEFILE_VERBOSE:BOOL=ON.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1109/index.html

@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2023 •
edited
Loading

Coverage Status

Coverage: 82.403%. Remained the same when pulling 3877c55 on add-sdl-flags into 5bfc097 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_8 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_9 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_10 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 84a4353 into master Mar 13, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-sdl-flags branch March 13, 2023 12:02
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_13 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls