Improved error handling for usm_ndarray.__setitem__ #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```python
import dpctl.tensor as dpt, numpy as np
u, n = dpt.empty(5), np.ones(5, dtype="O")
u[...] = n
```
This example used to raise a cascade of exceptions starting
with cryptic "RuntimeError: Unrecogized typenum 17 encountered.",
where typenum 17 corresponds to type object.
After this change, the error message is crisper:
```
ValueError: Input of type <class 'numpy.ndarray'> can not be \
assigned to usm_ndarray because of unsupported data \
type 'object'
```
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1146/index.html |
|
Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_38 ran successfully. |
npolina4
approved these changes
Mar 29, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_56 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #1139 the following suboptimal behavior was highlighted:
This example used to raise a cascade of exceptions starting with cryptic "RuntimeError: Unrecogized typenum 17 encountered.", where typenum 17 corresponds to type object. The latest exception raised was
ValueError.After this change, the error message is crisper:
Tests exist.