Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing platform test case. #116

Merged
merged 18 commits into from
Oct 8, 2020
Merged

Fix failing platform test case. #116

merged 18 commits into from
Oct 8, 2020

Conversation

diptorupd
Copy link
Contributor

Fixes for the scenarios where no sycl device except host exists.

Diptorup Deb added 18 commits October 7, 2020 16:08
Fix failing platform test case.
3f2929f
Skip if no non-host back end is there.
45cd6c2
Remove extra new line.
6f83a6b
change how the initial active queue is populated.
e716ef9
It is fine for the queue manager to store the host queue. Up to clien…
70fdbc2 
…ts what they want to do with it.
Fix gtests.
0d00a83
Add try catch...
10bdf28
handle exception.
7288482
Skip tests when no OpenCL devices are available.
6d84960
Skip more tests if no devices exist.
0169b7e
Skip Python tests.
d61cb8d
Skip Python test if no usable device exists.
3219dfb
Only report number of non-host platforms.
cc20ced
Add skip tests to test_sycl_usm.py
59b2ad1
Skip more tests if no platform is available.
d026cb7
Properly fix initialization of static variable.
420d12a
Do not create new std::vector.
2c471fd
Raise exception if DPPLSyclQueueRef is NULL.
907f624
@diptorupd
Copy link
Contributor Author

Closes #119

PokhodenkoSA
PokhodenkoSA approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked up to SDC on Linux.

@PokhodenkoSA PokhodenkoSA merged commit 9fcbaa5 into IntelPython:master Oct 8, 2020
@diptorupd diptorupd mentioned this pull request Oct 8, 2020
Closed
@diptorupd diptorupd deleted the fix/no_sycl_platform_available branch May 1, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PokhodenkoSA PokhodenkoSA PokhodenkoSA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
beta10
Development

Successfully merging this pull request may close these issues.
2 participants
@diptorupd @PokhodenkoSA