Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements dpctl.tensor.sqrt #1205

Merged
merged 2 commits into from
May 17, 2023
Merged

Implements dpctl.tensor.sqrt #1205

merged 2 commits into from
May 17, 2023

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented May 12, 2023 •
edited
Loading

This pull request implements dpctl.tensor.sqrt using the simplified ufunc interface.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1205/index.html

@oleksandr-pavlyk
Copy link
Collaborator

This PR needs some tests for sqrt function, and it can be merged.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_86 ran successfully.
Passed: 218
Failed: 782
Skipped: 116

@ndgrigorian ndgrigorian marked this pull request as ready for review May 17, 2023 21:25
@oleksandr-pavlyk oleksandr-pavlyk merged commit 40113bc into feature/elementwise-functions May 17, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the feature/elementwise-functions-sqrt branch May 17, 2023 22:28
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndgrigorian @oleksandr-pavlyk