Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpctl.tensor.sum reduction operation #1210

Merged
merged 10 commits into from
May 25, 2023
Merged

Implement dpctl.tensor.sum reduction operation #1210

merged 10 commits into from
May 25, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR adds implementation of sum-reduction over an axis of dpctl.tensor.usm_ndarray.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1210/index.html

@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.3dev1=py310h76be34b_116.

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the feature/elementwise-functions branch from 3cf142e to 62f2d46 Compare May 22, 2023 17:06
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the feature/sum-reduction branch from 2b69338 to 55711fd Compare May 22, 2023 17:07
@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.3dev1=py310h76be34b_117.

Base automatically changed from feature/elementwise-functions to master May 22, 2023 19:08
@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.3dev1=py310h76be34b_117.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_120 ran successfully.
Passed: 229
Failed: 771
Skipped: 116

@coveralls
Copy link
Collaborator

coveralls commented May 23, 2023 •
edited
Loading

Coverage Status

Coverage: 84.04% (+0.0006%) from 84.039% when pulling fcd0935 on feature/sum-reduction into a469906 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_121 ran successfully.
Passed: 229
Failed: 771
Skipped: 116

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_132 ran successfully.
Passed: 232
Failed: 768
Skipped: 116

@oleksandr-pavlyk
Renamed source/reductions.*pp to sum_reductions.*pp
f9ddea7 
Added MemoryOverap check, and the array range check per
FIXME note and PR review feedback.

Also consolidated transfer of iteration/reduction metadata
into a single operation to improve test stability on CPU
and improve overall host submission overhead time.
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev2=py310h7bf5fec_15 ran successfully.
Passed: 234
Failed: 766
Skipped: 116

@ndgrigorian ndgrigorian self-requested a review May 25, 2023 22:00
ndgrigorian
ndgrigorian approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev2=py310h7bf5fec_17 ran successfully.
Passed: 233
Failed: 767
Skipped: 116

@oleksandr-pavlyk oleksandr-pavlyk merged commit 521867b into master May 25, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the feature/sum-reduction branch May 25, 2023 22:18
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev2=py310h7bf5fec_20 ran successfully.
Passed: 234
Failed: 766
Skipped: 116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian