Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiply and subtract #1211

Merged
merged 4 commits into from
May 24, 2023
Merged

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR adds dpctl.tensor.multiply and dpctl.tensor.subtract.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented May 22, 2023

Coverage Status

Coverage: 84.039% (+0.005%) from 84.034% when pulling f25053f on feature/multiply-and-subtract into 18d1728 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_118 ran successfully.
Passed: 231
Failed: 769
Skipped: 116

Removed dead code for isinf/isnan .hpp files.
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_119 ran successfully.
Passed: 232
Failed: 768
Skipped: 116

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_124 ran successfully.
Passed: 230
Failed: 770
Skipped: 116

@ndgrigorian ndgrigorian self-requested a review May 24, 2023 18:35
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleksandr-pavlyk oleksandr-pavlyk merged commit a469906 into master May 24, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the feature/multiply-and-subtract branch May 24, 2023 19:07
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_124 ran successfully.
Passed: 232
Failed: 768
Skipped: 116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants