Implementation of dpctl.tensor.not_equal function #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpctl/tensor/libtensor/include/kernels/elementwise_functions/not_equal.hpp
Outdated
Show resolved
Hide resolved
dpctl/tensor/_elementwise_funcs.py
Outdated
| @@ -261,7 +261,27 @@ | |||
| # FIXME: implement U25 | |||
|
|
|||
| # B20: ==== NOT_EQUAL (x1, x2) | |||
| # FIXME: implement B20 | |||
| _not_equal_docstring_ = """ | |||
| not_equal(x1, x2, order='K') | |||
There was a problem hiding this comment.
Add out keyword, and describe it in Args section. Look at @vtavana PR for sin/exp for my changes to abs docstring.
vlad-perevezentsev
requested review from
ndgrigorian,
vtavana,
npolina4 and
antonwolfy
vlad-perevezentsev
force-pushed
the
not_equal_impl
branch
from
de1c1b1 to
cee2e0a
Compare
ndgrigorian
approved these changes
Jun 8, 2023
|
Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_25 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
dpctl.tensor.not_equalfunction and tests for it