Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/elementwise functions real imag conj #1217

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Feature/elementwise functions real imag conj #1217

merged 3 commits into from
Jun 2, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 26, 2023 •
edited
Loading

In this PR, dpctl.tensor.real, dpctl.tensor.imag, dpctl.tensor.conj, and dpctl.tensor.proj are added and tested.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1217/index.html

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev2=py310h7bf5fec_12 ran successfully.
Passed: 247
Failed: 753
Skipped: 116

@vtavana vtavana force-pushed the feature/elementwise-functions-real-imag-conj branch from 071a618 to 4571a66 Compare May 26, 2023 16:55
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev2=py310h7bf5fec_12 ran successfully.
Passed: 247
Failed: 753
Skipped: 116

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev2=py310h7bf5fec_14 ran successfully.
Passed: 247
Failed: 753
Skipped: 116

@vtavana vtavana force-pushed the feature/elementwise-functions-sin-exp branch from 812ea72 to 5314ddd Compare May 31, 2023 04:17
@vtavana vtavana force-pushed the feature/elementwise-functions-real-imag-conj branch from 6dd8e15 to a952d4e Compare May 31, 2023 19:52
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_21 ran successfully.
Passed: 274
Failed: 726
Skipped: 116

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_22 ran successfully.
Passed: 274
Failed: 726
Skipped: 116

@vtavana vtavana force-pushed the feature/elementwise-functions-real-imag-conj branch 8 times, most recently from 545de34 to 200c106 Compare June 2, 2023 00:12
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_12 ran successfully.
Passed: 272
Failed: 728
Skipped: 116

vtavana and others added 2 commits June 1, 2023 19:21
@vtavana
impl_real_imag_conj
6b28198
@ndgrigorian @vtavana
Rewrites proj to use a custom implementation
4c9a340 
- Avoids bug on CPU that results in incorrect result
@vtavana vtavana force-pushed the feature/elementwise-functions-real-imag-conj branch from 200c106 to 4c9a340 Compare June 2, 2023 00:22
@vtavana vtavana marked this pull request as ready for review June 2, 2023 00:29
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_11 ran successfully.
Passed: 272
Failed: 728
Skipped: 116

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_12 ran successfully.
Passed: 274
Failed: 726
Skipped: 116

@ndgrigorian ndgrigorian merged commit 18d1641 into feature/elementwise-functions-sin-exp Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@vtavana vtavana deleted the feature/elementwise-functions-real-imag-conj branch June 4, 2023 01:53
@vtavana vtavana self-assigned this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk left review comments

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @oleksandr-pavlyk @ndgrigorian