Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented floor_divide() function. #1221

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented May 31, 2023

Implemented floor_divide() function and tests for it

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented May 31, 2023

Coverage Status

coverage: 84.037% (+0.002%) from 84.035% when pulling 1c18270 on implemented_floor_divide into 1596a13 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_9 ran successfully.
Passed: 261
Failed: 739
Skipped: 116

@oleksandr-pavlyk
Copy link
Collaborator

Please run your changes through the linter.

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_19 ran successfully.
Passed: 276
Failed: 724
Skipped: 119

@npolina4 npolina4 merged commit 47466ee into master Jun 12, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_31 ran successfully.
Passed: 346
Failed: 654
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk deleted the implemented_floor_divide branch July 11, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants