Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of less_equal, greater, greater_equal for dpctl.tensor #1239

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Implementation of less_equal, greater, greater_equal for dpctl.tensor #1239

merged 5 commits into from
Jun 13, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR adds comparison functions such as less_equal ,greater and greater_equal for dpctl.tensor and tests for them

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jun 13, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jun 13, 2023 •
edited
Loading

Coverage Status

coverage: 84.11% (+0.007%) from 84.103% when pulling 20cbd36 on vlad-perevezentsev:comparison_funcs into 0185fa9 on IntelPython:master.

ndgrigorian
ndgrigorian approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vlad-perevezentsev!

@ndgrigorian ndgrigorian merged commit 43f3b7b into IntelPython:master Jun 13, 2023
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_40 ran successfully.
Passed: 359
Failed: 641
Skipped: 119

@vlad-perevezentsev vlad-perevezentsev deleted the comparison_funcs branch June 20, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-perevezentsev @coveralls @ndgrigorian