Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements types property for elementwise functions #1361

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

ndgrigorian
Copy link
Collaborator

This PR implements a types property for elementwise function. This property returns a list of strings indicating the types an elementwise function can accept without casting, and what type it will output.

The lists are lazily initialized, and stored on a new member on the elementwise function object.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • [] Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

- Output corresponds with Numpy's: a list with an arrow marking the domain to range type map
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.624% (+0.03%) from 85.598% when pulling dc3ebd1 on elementwise-types-property into abc8c80 on master.

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_5 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@ndgrigorian ndgrigorian merged commit 4cc552f into master Aug 21, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@oleksandr-pavlyk oleksandr-pavlyk deleted the elementwise-types-property branch August 21, 2023 16:10
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_3 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants