Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to matmul codebase: reducing line-count #1525

Merged
merged 2 commits into from
Feb 5, 2024
Merged

changes to matmul codebase: reducing line-count #1525

merged 2 commits into from
Feb 5, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Used if constexpr to make m_groups=1 specializations of functors unnecessary.

Also used const references for vectors in some places.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Reduce code duplication
c521e41 
Wrote functors using 'if constexpr' to avoid use of m_groups = 1
specializations.
@oleksandr-pavlyk
Use const references for read-use-only vectors
e3f4160
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.065%. remained the same
when pulling e3f4160 on gemm-cleanup
into 6089e81 on master.

@ndgrigorian ndgrigorian self-requested a review February 5, 2024 18:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_69 ran successfully.
Passed: 907
Failed: 2
Skipped: 86

ndgrigorian
ndgrigorian approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 89266a7 into master Feb 5, 2024
49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the gemm-cleanup branch February 5, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian