Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes out kwarg in matmul when axes are appended to inputs #1610

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

ndgrigorian
Copy link
Collaborator

This PR corrects behavior of matmul to properly account for appending of axes to inputs where one or both arguments are vectors.

Previously, these cases would raise an error, and require an out array with axes appended by the user.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Mar 27, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Mar 27, 2024

Coverage Status

coverage: 87.952% (+0.01%) from 87.941%
when pulling 55fef8e on matmul-out-dim-fix
into d7c54e4 on master.

Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_153 ran successfully.
Passed: 839
Failed: 0
Skipped: 92

1 similar comment
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_153 ran successfully.
Passed: 839
Failed: 0
Skipped: 92

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ndgrigorian !

Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_154 ran successfully.
Passed: 839
Failed: 0
Skipped: 92

@ndgrigorian ndgrigorian merged commit e22412f into master Mar 27, 2024
45 of 46 checks passed
@ndgrigorian ndgrigorian deleted the matmul-out-dim-fix branch March 27, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants