Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle possible NULL return from DPCTLDevice_GetMaxWorkGroupSize1d, 2d #1690

Merged
merged 1 commit into from
May 22, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Python code now checks that the return value of DPCTLDevice_GetMaxWorkGroupSize1d and DPCTLDevice_GetMaxWorkGroupSize2d is not NULL before dereferencing.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Python code now checks that the return value is not NULL before
dereferencing.
Copy link

github-actions bot commented May 22, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.943% (-0.03%) from 87.971%
when pulling 3952ef7 on handle-possible-errors
into 183bfd7 on master.

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_8 ran successfully.
Passed: 889
Failed: 16
Skipped: 91

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 4dac76c into master May 22, 2024
57 of 60 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the handle-possible-errors branch May 22, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants