-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove USE_SYCL_FOR_COMPLEX_TYPES #1707
Remove USE_SYCL_FOR_COMPLEX_TYPES #1707
Conversation
Always use SYCL namespace functions. Also replaced some std namespace functions with corresponding sycl namespace functions.
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_66 ran successfully. |
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_67 ran successfully. |
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_68 ran successfully. |
Tested build with CUDA and it built successfully, so this LGTM. Since I had to add pre-commit changes, can @antonwolfy or @vtavana please take a look at the changes and review this PR? To keep score up. I still see some uses of |
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_69 ran successfully. |
The last commit, although green in CI, no longer build for NVPTX64 target, crashing during build of It is best to report this to the attention of compiler engineers as a standalone reproducer and revert the culprit. Crash log
|
Culprit appears to be |
…er crash on CUDA is resolved
A few stray instances of `signbit`, `atan`, `log`, and `exp` as well as `atan2` and `hypot`
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_71 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With sycl::log1p
to std::log1p
change for logaddexp
and remaining std
functions changed, CUDA builds and tests seem to pass. I think the PR is ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndgrigorian, dpnp
tests passed with these changes without any new issue.
Always use SYCL namespace functions. Also replaced some std namespace functions with corresponding sycl namespace functions.