Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed use of deprecated SYCL_DEVICE_FILTER #1740

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Removed use of deprecated SYCL_DEVICE_FILTER #1740

merged 1 commit into from
Jul 19, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Replaced it with ONEAPI_DEVICE_SELECTOR environment variable.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Removed use of deprecated SYCL_DEVICE_FILTER
861bf48 
Replaced it with ONEAPI_DEVICE_SELECTOR environment
variable.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_132 ran successfully.
Passed: 894
Failed: 15
Skipped: 105

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.953%. remained the same
when pulling 861bf48 on remove-mention-of-deprecated-env-variable
into d191e97 on master.

antonwolfy
antonwolfy approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me. Thank you @oleksandr-pavlyk

@oleksandr-pavlyk oleksandr-pavlyk merged commit 0306b10 into master Jul 19, 2024
43 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the remove-mention-of-deprecated-env-variable branch July 19, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @antonwolfy