Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bootstrap channel for Windows build too #1748

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This change should enable Windows build to have the same NumPy pinning as Linux, that is >=1.23,<2.0a0 instead of >=1.26,<2.0a0, by ensuring that NumPy 1.23 from bootstrap channels gets installed into build environment.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Jul 22, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_151 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.966%. remained the same
when pulling f3b41c9 on use-bootstrap-channel-for-windows
into 0ec8cfb on master.

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pinning looks good now:

$ mamba search dpctl -i --platform win-64 -c /home/xantvol/bits/dpctl --override-channels
Loading channels: done
dpctl 0.18.0dev0 py311h82bb817_151
----------------------------------
file name   : dpctl-0.18.0dev0-py311h82bb817_151.tar.bz2
name        : dpctl
version     : 0.18.0dev0
build       : py311h82bb817_151
build number: 151
size        : 21.1 MB
license     : Apache-2.0
subdir      : win-64
url         : file:///home/xantvol/bits/dpctl/win-64/dpctl-0.18.0dev0-py311h82bb817_151.tar.bz2
md5         : b7193345a5558c2d04a947114f85f23c
timestamp   : 2024-07-22 05:22:13 UTC
dependencies:
  - dpcpp-cpp-rt >=2024.2,<2025.0a0
  - intel-cmplr-lib-rt >=2024.2,<2025.0a0
  - level-zero >=1.17.19,<2.0a0
  - numpy >=1.23,<2.0a0
  - numpy >=1.23.5,<2.0a0
  - python >=3.11,<3.12.0a0
  - vc >=14.1,<15
  - vc14_runtime >=14.16.27033

Thank you @oleksandr-pavlyk

@oleksandr-pavlyk oleksandr-pavlyk merged commit e35dfa8 into master Jul 22, 2024
37 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the use-bootstrap-channel-for-windows branch July 22, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants