Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax hard pinning for build time compiler #1752

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Relax hard pinning for build time compiler #1752

merged 1 commit into from
Jul 23, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Jul 23, 2024 •
edited
Loading

This PR replaces hard pinning of compiler version in build environment to >=.

This allows internal CI to build with future version of compiler as well.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Relax hard pinning for build time compiler
cd3e530 
This allows internal CI to build with future version
of compiler as well.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.965%. remained the same
when pulling cd3e530 on relax-compiler-pinning
into 5164f99 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_158 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

antonwolfy
antonwolfy approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests in internal CI are passing now. Thank you @oleksandr-pavlyk

@oleksandr-pavlyk oleksandr-pavlyk merged commit 7450558 into master Jul 23, 2024
42 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the relax-compiler-pinning branch July 23, 2024 13:03
ZzEeKkAa
ZzEeKkAa reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oleksandr-pavlyk . I could have missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzEeKkAa ZzEeKkAa ZzEeKkAa left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oleksandr-pavlyk @coveralls @ZzEeKkAa @antonwolfy