-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop use of soversion for dpctl sycl interface #1773
Drop use of soversion for dpctl sycl interface #1773
Conversation
cb4286d
to
8733570
Compare
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_194 ran successfully. |
Library SOVersioning is used to allow libraries of different versions to coexist in the same layout. Since libDPCTLSyclInterface library is being installed into site-packages/dpctl, and since Python does not support multiple versions of the same package installed, such a situation where SOVersioning is required never arises. SOVersioning causes creation of symbolic links which are not supported by Python wheels (symbolic links are followed and 3 hard identical copies of the library are bing created) and only cause wheel size to be overinflated. With all this said, it is better to not set VERSION/SOVERSION target property.
The test would still pass when it is turned back on and symbolic links are present.
3bd48d3
to
1364ec4
Compare
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_198 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked locally. Everything works smooth if dpnp is rebuilt on top on these changes and numba-dpex library import updates name from *.so.0
to *.so
at load_dpctl_sycl_interface
Turns off SOVERSION-ing of libDPCTLSyclInterface
Library SOVersioning is used to allow libraries of different versions
to coexist in the same layout. Since libDPCTLSyclInterface library
is being installed into site-packages/dpctl, and since Python does
not support multiple versions of the same package installed, such a
situation where SOVersioning is required never arises.
SOVersioning causes creation of symbolic links which are not supported
by Python wheels (symbolic links are followed and 3 hard identical
copies of the library are bing created) and only cause wheel size
to be overinflated.
With all this said, it is better to not set VERSION/SOVERSION
target property.