Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop use of soversion for dpctl sycl interface #1773

Merged

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Turns off SOVERSION-ing of libDPCTLSyclInterface

Library SOVersioning is used to allow libraries of different versions
to coexist in the same layout. Since libDPCTLSyclInterface library
is being installed into site-packages/dpctl, and since Python does
not support multiple versions of the same package installed, such a
situation where SOVersioning is required never arises.

SOVersioning causes creation of symbolic links which are not supported
by Python wheels (symbolic links are followed and 3 hard identical
copies of the library are bing created) and only cause wheel size
to be overinflated.

With all this said, it is better to not set VERSION/SOVERSION
target property.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the drop-use-of-soversion-for-DPCTLSyclInterface branch from cb4286d to 8733570 Compare July 30, 2024 21:19
Copy link

github-actions bot commented Jul 30, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Jul 30, 2024

Coverage Status

coverage: 87.609%. remained the same
when pulling 1364ec4 on drop-use-of-soversion-for-DPCTLSyclInterface
into 7fa98fa on master.

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_194 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Library SOVersioning is used to allow libraries of different versions
to coexist in the same layout. Since libDPCTLSyclInterface library
is being installed into site-packages/dpctl, and since Python does
not support multiple versions of the same package installed, such a
situation where SOVersioning is required never arises.

SOVersioning causes creation of symbolic links which are not supported
by Python wheels (symbolic links are followed and 3 hard identical
copies of the library are bing created) and only cause wheel size
to be overinflated.

With all this said, it is better to not set VERSION/SOVERSION
target property.
The test would still pass when it is turned back on and
symbolic links are present.
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the drop-use-of-soversion-for-DPCTLSyclInterface branch from 3bd48d3 to 1364ec4 Compare July 31, 2024 18:27
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_198 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally. Everything works smooth if dpnp is rebuilt on top on these changes and numba-dpex library import updates name from *.so.0 to *.so at load_dpctl_sycl_interface

@oleksandr-pavlyk oleksandr-pavlyk merged commit d79dae1 into master Aug 2, 2024
48 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the drop-use-of-soversion-for-DPCTLSyclInterface branch August 2, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants