Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clang-format version used #1775

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Update clang-format version used #1775

merged 3 commits into from
Jul 31, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This resolves gh-1708. The goal is to use clang-format aligned with Ubuntu 24.04

$ lsb_release --all
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 24.04 LTS
Release:        24.04
Codename:       noble

$ clang-format --version
Ubuntu clang-format version 18.1.3 (1)

Update clang-format version in cpp_style_checks

Updated Ubuntu container version in pre-commit workflow to the latest.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_192 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Jul 31, 2024 •
edited
Loading

Coverage Status

coverage: 87.606% (-0.003%) from 87.609%
when pulling bad1b4e on update-clang-format-version-used
into 7fa98fa on master.

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the update-clang-format-version-used branch from 918ea99 to 9514ac3 Compare July 31, 2024 14:53
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_194 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_195 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the update-clang-format-version-used branch from 9514ac3 to aeae93e Compare July 31, 2024 15:25
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_194 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the update-clang-format-version-used branch 3 times, most recently from 6a84594 to f50c1af Compare July 31, 2024 16:00
@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review July 31, 2024 16:06
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_194 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

3 similar comments
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_194 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_194 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_194 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the update-clang-format-version-used branch from f50c1af to bad1b4e Compare July 31, 2024 18:17
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_198 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

ndgrigorian
ndgrigorian approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format currently works out-of-the-box on Ubuntu 24.04 and pre-commit passes for all files without any work-around.

Since no (actively being worked on) PRs are open which touch C++ code, I think it would be good to merge this sooner rather than later.

Thank you @oleksandr-pavlyk !

@oleksandr-pavlyk oleksandr-pavlyk merged commit f98fe15 into master Jul 31, 2024
47 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the update-clang-format-version-used branch July 31, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transition dpctl CI to use clang-format-18
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian