Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing include to fix build break #1776

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add missing include to fix build break #1776

merged 1 commit into from
Jul 31, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

"libsyclinterface/source/dpctl_sycl_queue_manager.cpp" used std::stringstream but was not including sstream header.

This caused build break in internal CI with forthcoming compiler.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_192 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.609%. remained the same
when pulling be2a526 on fix-build-break-add-missing-include
into 1462d8c on master.

ekomarova
ekomarova approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@ekomarova ekomarova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

ndgrigorian
ndgrigorian approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds now work, LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 69cba9a into master Jul 31, 2024
44 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-build-break-add-missing-include branch July 31, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekomarova ekomarova ekomarova approved these changes

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oleksandr-pavlyk @coveralls @ndgrigorian @ekomarova