Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff raises an exception for negative values of n #1780

Merged
merged 1 commit into from
Aug 2, 2024
Merged

diff raises an exception for negative values of n #1780

merged 1 commit into from
Aug 2, 2024

Conversation

ndgrigorian
Copy link
Collaborator

diff now raises an exception for negative n as is expected, rather than just defaulting to n=1 case

Closes #1779

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Close gh-1779
fc3b4f3 
`diff` now raises an exception for negative `n` as expected
antonwolfy
antonwolfy approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_231 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.739% (+0.003%) from 87.736%
when pulling fc3b4f3 on diff-error-negative-n
into 1ecd8a8 on master.

@ndgrigorian ndgrigorian merged commit 2d964d9 into master Aug 2, 2024
48 of 49 checks passed
@ndgrigorian ndgrigorian deleted the diff-error-negative-n branch August 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk oleksandr-pavlyk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dpt.diff does not raise a validation exception for n < 0
3 participants
@ndgrigorian @coveralls @antonwolfy