Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for ur_adapter_opencl alongside pi_opencl #1788

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Search for ur_adapter_opencl and ur_adapter_level_zero alongside pi_opencl and pi_level_zero to accomodate building with both DPC++ 2024.2.0 and open source build of DPC++, a precursor for the forthcoming version of DPC++.

intel/llvm DPC++ has made switch to using unified runtimes, and the compiler nightly build artifacts no longer contain pi_level_zero.so and pi_opencl.so libraries that we used to infer the SO-versioned name of ze_loader and OpenCL loader libraries from.

This change adds ur_adapter_* names to find_library CMake commands.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

intel/llvm DPC++ has made switch to using unified runtimes,
and the compiler nightly build artifacts no longer contain
pi_level_zero.so and pi_opencl.so libraries that we used
to infer the SO-versioned name of ze_loader and OpenCL loader
libraries from.

This change adds ur_adapter_* names to find_library CMake
commands.
Copy link

github-actions bot commented Aug 6, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

github-actions bot commented Aug 6, 2024

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_256 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.93%. remained the same
when pulling 7fd494c on get-ready-for-ur-adapters
into b9242f4 on master.

@oleksandr-pavlyk
Copy link
Collaborator Author

Building with intel/llvm dpc++ has recovered the step of getting LIB_ZE and LIB_CL

-- LIB_ZE: libze_loader.so.1

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleksandr-pavlyk oleksandr-pavlyk merged commit e3592bd into master Aug 7, 2024
48 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the get-ready-for-ur-adapters branch August 7, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants