Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed obvious unreferenced bug in copy-and-cast logic #1799

Merged

Conversation

oleksandr-pavlyk
Copy link
Collaborator

The special casing of copy-and-cast operation after stride simplification, the branch where memcpy is applicable did not set returned event to the intended variable, but rather to the local-scoped one.

This change fixes that logic.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

The special casing of copy-and-cast operation after stride simplification,
the branch where memcpy is applicable did not set returned event to the intended
variable, but rather to the local-scoped one.

This change fixes that logic.
Copy link

github-actions bot commented Aug 14, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.883%. remained the same
when pulling 79dc399 on fix-unreference-bug-in-copying-between-usm-ndarrays
into 76b2eb0 on master.

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_307 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit 08b3517 into master Aug 14, 2024
46 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-unreference-bug-in-copying-between-usm-ndarrays branch August 14, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants