Explicitly include headers used in the c++ file pertaining to reduction #1802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a good, recommended practice.
Moved global definition of namespaces
td_ns
andsu_ns
in 'reductions.hpp' into namespace.Fixed resulting build breakage by including needed headers and defining those namespaces locally in affected files.
Changed definition of
logaddexp
inmath_utils.hpp
to use selector instead of if/else branches to improve performance. Switch revealed silent inefficiency from usingstd::log1
p for all types (forsycl::half
it would silently upcast to float and evaluatestd::log1p<float>(sycl::half)
).Used
if constexpr
to use sycl::log1p for half and single FP types. For double, use std::log1p until the issue is fixed.