Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed post-link and pre-unlink scripts #1821

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

They provided a crutch, which is now handled by
intel-gpu-ocl-icd-system conda package, which a user may install as needed.

Since MKL currently requires OpenCL GPU device to be available, dpnp has run-time dependency on
intel-gpu-ocl-icd-system to make OpenCL GPU device discoverable by OpenCL loader from Python environment.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

They provided a crutch, which is now handled by
intel-gpu-ocl-icd-system conda package, which a user
may install as needed.

Since MKL currently requires OpenCL GPU device to be
available, dpnp has run-time dependency on
intel-gpu-ocl-icd-system to make OpenCL GPU device
discoverable by OpenCL loader from Python environment.
Copy link

github-actions bot commented Sep 5, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@oleksandr-pavlyk
Copy link
Collaborator Author

The scripts being removed here were added in 7dc575a

Copy link

github-actions bot commented Sep 5, 2024

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_395 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.893%. remained the same
when pulling b767dcb on remove-post-link-and-pre-unlink-scripts
into aad69b0 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 3f0dcb2 into master Sep 6, 2024
41 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the remove-post-link-and-pre-unlink-scripts branch September 6, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants