Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates black version used in Python code style workflow #1828

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Updates black version used in Python code style workflow #1828

merged 2 commits into from
Sep 10, 2024

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Sep 10, 2024 •
edited by oleksandr-pavlyk
Loading

Version in pre-commit config differed from the version in the workflow, which could lead to conflicts between the workflow and pre-commit.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian marked this pull request as ready for review September 10, 2024 04:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_9 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Sep 10, 2024 •
edited
Loading

Coverage Status

coverage: 87.893%. remained the same
when pulling 297fd54 on update-black-python-code-style-workflow
into f483deb on master.

oleksandr-pavlyk
oleksandr-pavlyk previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ndgrigorian

I wonder if instead of adding to CHANGELOG directly, we should automate keeping track of changes.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_10 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The section "Maintenance" is overdue :)

@ndgrigorian ndgrigorian merged commit cd7d41c into master Sep 10, 2024
49 of 53 checks passed
@ndgrigorian ndgrigorian deleted the update-black-python-code-style-workflow branch September 10, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk