Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support python 3.13 #1941

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Support python 3.13 #1941

merged 3 commits into from
Dec 18, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Fix native extension code for Python 3.13 (account to removal of _Py_IsFinilizing() as it is replaced by Py_IsFinilizing()).

Build and test with Python 3.13 in conda package workflow.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_348 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Dec 18, 2024 •
edited
Loading

Coverage Status

coverage: 87.659%. remained the same
when pulling cc902e7 on support-python-3.13
into 98f96e7 on master.

@oleksandr-pavlyk
Copy link
Collaborator Author

@ethanglaser dpctl's support for Python 3.13 is added in this PR.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_349 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

ndgrigorian
ndgrigorian approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for 3.13 so LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 25a961f into master Dec 18, 2024
60 of 61 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the support-python-3.13 branch December 18, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian