Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional qualified cpp types #1955

Merged

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Fixed a single instance of unqualified size_t picked up after rebasing.

Also fixed unqualified uint8_t, uint16_t, etc. in dpctl/tensor/libtensor.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Jan 6, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

github-actions bot commented Jan 6, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_402 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

Copy link

github-actions bot commented Jan 6, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_404 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the additional-qualified-cpp-types branch from 9e613b8 to 5c92afe Compare January 6, 2025 18:34
Copy link

github-actions bot commented Jan 6, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_405 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@oleksandr-pavlyk oleksandr-pavlyk merged commit 1eebdf2 into use-std-size-t-cstddef Jan 6, 2025
59 of 61 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the additional-qualified-cpp-types branch January 6, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants