Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioneer as build requirement in documentation #1972

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

ndgrigorian
Copy link
Collaborator

This PR adds to the documentation that versioneer is a build requirement for dpctl.

It is listed in pyproject.toml, but not referenced in docs.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Jan 16, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@oleksandr-pavlyk
Copy link
Collaborator

I may have spoken too soon. Two CI jobs on Linux failed, but I do not yet understand whether the failure was caused by this change, or by a change in conda toolchain

@ndgrigorian
Copy link
Collaborator Author

I may have spoken too soon. Two CI jobs on Linux failed, but I do not yet understand whether the failure was caused by this change, or by a change in conda toolchain

It must be the Conda toolchain, this only changes the documentation, which built fine too

@coveralls
Copy link
Collaborator

coveralls commented Jan 16, 2025

Coverage Status

coverage: 87.734%. first build
when pulling 1326b36 on add-versioneer-to-how-to-build
into a7e85a2 on master.

@ndgrigorian ndgrigorian force-pushed the add-versioneer-to-how-to-build branch from 43fbadb to 1326b36 Compare January 17, 2025 00:48
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_474 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian ndgrigorian merged commit 360ce45 into master Jan 17, 2025
47 of 59 checks passed
@ndgrigorian ndgrigorian deleted the add-versioneer-to-how-to-build branch January 17, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants