-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python coverage to use pytest-cov #369
Update Python coverage to use pytest-cov #369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Waiting for CI.
@@ -2,4 +2,4 @@ | |||
plugins = Cython.Coverage | |||
branch = True | |||
source = dpctl | |||
omit = dpctl/tests/*, *__init__.py | |||
omit = dpctl/tests/*, dpctl/_version.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why dpctl/_version.py
ignored?
I have merged because tests passed. Coverage statistics reporting failed
Traceback (most recent call last):
File "$PREFIX/lib/python3.7/site-packages/teamcity_messages-1.25-py3.7.egg/teamcity/pytest_plugin.py", line 371, in pytest_terminal_summary
self._report_coverage()
File "$PREFIX/lib/python3.7/site-packages/teamcity_messages-1.25-py3.7.egg/teamcity/pytest_plugin.py", line 378, in _report_coverage
from coverage.report import Reporter
ImportError: cannot import name 'Reporter' from 'coverage.report' ($PREFIX/lib/python3.7/site-packages/coverage/report.py) It should be fixed by SAT-3964. |
|
Blocked by SAT-3964. Waiting for coverage package on internal CI.
Closes #280.
Implemented coverage only on Linux. On Windows tests run without coverage.