Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python coverage to use pytest-cov #369

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

vlad-perevezentsev
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Apr 6, 2021

Blocked by SAT-3964. Waiting for coverage package on internal CI.
Closes #280.
Implemented coverage only on Linux. On Windows tests run without coverage.

@vlad-perevezentsev vlad-perevezentsev added 3 - Waiting: CI coverage Tasks related with code coverage labels Apr 6, 2021
@vlad-perevezentsev vlad-perevezentsev self-assigned this Apr 6, 2021
@vlad-perevezentsev vlad-perevezentsev linked an issue Apr 6, 2021 that may be closed by this pull request
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Waiting for CI.

@@ -2,4 +2,4 @@
plugins = Cython.Coverage
branch = True
source = dpctl
omit = dpctl/tests/*, *__init__.py
omit = dpctl/tests/*, dpctl/_version.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why dpctl/_version.py ignored?

@PokhodenkoSA PokhodenkoSA merged commit c3b9199 into IntelPython:master Apr 6, 2021
@PokhodenkoSA
Copy link
Contributor

I have merged because tests passed.
In CI you can see

  Coverage statistics reporting failed
  Traceback (most recent call last):
    File "$PREFIX/lib/python3.7/site-packages/teamcity_messages-1.25-py3.7.egg/teamcity/pytest_plugin.py", line 371, in pytest_terminal_summary
      self._report_coverage()
    File "$PREFIX/lib/python3.7/site-packages/teamcity_messages-1.25-py3.7.egg/teamcity/pytest_plugin.py", line 378, in _report_coverage
      from coverage.report import Reporter
  ImportError: cannot import name 'Reporter' from 'coverage.report' ($PREFIX/lib/python3.7/site-packages/coverage/report.py)

It should be fixed by SAT-3964.

@PokhodenkoSA
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev deleted the use_pytest_cov branch June 20, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Waiting: CI coverage Tasks related with code coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Pyton coverage to use Pytest-cov
2 participants