Fix for slicing bugs #441
Merged
Fix for slicing bugs #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-pavlyk
force-pushed
the
fix-slicing-bugs
branch
from
759a57e to
3847ad2
Compare
These were discovered while preparing for customer presentation
'i4' translates to typenum 5 on Linux, but to typenum 7 on Windows, and this entry in the look-up array was not meaningfully populated
oleksandr-pavlyk
force-pushed
the
fix-slicing-bugs
branch
from
51b08cc to
cc201c3
Compare
This uses dpctl.SyclQueue() to create the queue from default selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bugs in basic slicing and in constructors discovered by examples used during customer presentation.
Specifically these had to deal with negative strides and sometimes non-unit strides.
For
Xusm = dpt.usm_ndarray((12,), dtype='i4'), andXusm[1::2]had incorrect shape of(5,), while the expected shape should be(6,), consisting of elements of{Xsum[1], Xusm[3], Xusm[5], Xusm[7], Xusm[9], Xusm[11]}.Expanded tests, and fixed memory leak in shape/strides parser on failures (C-array for shape was not being freed).