Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sub devices #479

Merged
merged 4 commits into from
May 27, 2021
Merged

Fix sub devices #479

merged 4 commits into from
May 27, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented May 27, 2021 •
edited
Loading

Closes #475

Issue alike crash of dpctl.SyclDevice("cpu").create_sub_devices(partition=0) should be fixed.

@oleksandr-pavlyk
In CreateSubDevicesEqually and ByCounts check that counts by positive
54c61a4 
Also change error handling in CreateSubDevicesByCounts.
@oleksandr-pavlyk
SyclDevice.create_sub_devices checks partition argument better
f563d87 
Use of zero EU counts now raises and error.
@coveralls
Copy link
Collaborator

coveralls commented May 27, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 60.917% when pulling 5d23a0a on fix-sub-devices into 48794f7 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 76680ff into master May 27, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-sub-devices branch May 27, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@1e-to 1e-to Awaiting requested review from 1e-to

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault in creating sub-devices
3 participants
@oleksandr-pavlyk @coveralls @diptorupd