Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate configurations of tools that support PEP 518 into pyproject.toml #486

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

diptorupd
Copy link
Contributor

coverage and pytest support PEP518 and pyproject.toml. The PR moves configurations for these tools into pyproject.toml.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 60.917% when pulling a0f0df6 on diptorupd:fix/config_hell into 0951961 on IntelPython:master.

@diptorupd diptorupd merged commit 6cfc2a6 into IntelPython:master Jun 2, 2021
@diptorupd diptorupd deleted the fix/config_hell branch June 2, 2021 15:24
[tool.pytest.ini.options]
minversion = "6.0"
norecursedirs= [
".*", "*.egg*", "build", "dist", "conda.recipe",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean "conda-recipe"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arg! sorry for merging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typo was there always in our config. I copy-pasted without noticing.

diptorupd pushed a commit to diptorupd/dpctl that referenced this pull request Jun 22, 2021
…ct.toml (IntelPython#486)

* Consolidate some of the configs into pyproject.toml

* Update github workflow to install coverage with toml support.

  - Also update CONTRIBUTING.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants