Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SDL check #487

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix SDL check #487

merged 1 commit into from
Jun 2, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Jun 2, 2021 •
edited
Loading

Follow DPCTLDevice_CreateFromSelector which passes the check.

This should fix an issue from SAT-4170:

Possible memory leak. Dynamic memory stored in 'P' allocated through function 'new' at line 84 can be lost at line 88

@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.03%) to 60.889% when pulling 5baf591 on try-fixing-sdl-loner into 0951961 on master.

@oleksandr-pavlyk oleksandr-pavlyk changed the title Follow DPCTLDevice_CreateFromSelector which passes the check Fix SDL check Jun 2, 2021
diptorupd
diptorupd approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 4513a1d into master Jun 2, 2021
diptorupd pushed a commit to diptorupd/dpctl that referenced this pull request Jun 22, 2021
@oleksandr-pavlyk
Follow DPCTLDevice_CreateFromSelector which passes the check (IntelPy…
3d1de13 
…thon#487)
@oleksandr-pavlyk oleksandr-pavlyk deleted the try-fixing-sdl-loner branch August 20, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @diptorupd