Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for dpctl_sycl_queue_interface #492

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

diptorupd
Copy link
Contributor

Improvements to dpctl_c_api

  • Add missing checks to dpctl_sycl_queue_interface.cpp
  • Add error messages to dpctl_sycl_program_interface.cpp inside the level-zero module creation function.
  • Refactor the unit tests for dpctl_sycl_queue_interface.cpp introducing negative test cases.
  • Moved the queue submit test cases into a separate source file.

Note - Unit tests for DPCTLQueue_Memcpy and family are not added here. I will be adding them in a separate PR.

@diptorupd diptorupd force-pushed the fix/c_api_queue_tests branch from 7f5688a to 50ec561 Compare June 22, 2021 22:49
@diptorupd diptorupd force-pushed the fix/c_api_queue_tests branch from 50ec561 to e4fa0be Compare June 22, 2021 22:54
@coveralls
Copy link
Collaborator

coveralls commented Jun 22, 2021

Coverage Status

Coverage increased (+1.5%) to 62.29% when pulling 57488e1 on diptorupd:fix/c_api_queue_tests into 227a126 on IntelPython:master.

@diptorupd diptorupd force-pushed the fix/c_api_queue_tests branch from c4c3059 to 57488e1 Compare June 23, 2021 04:42
@diptorupd diptorupd merged commit d01369e into IntelPython:master Jun 23, 2021
@diptorupd diptorupd deleted the fix/c_api_queue_tests branch June 23, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants