Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new DPCTLEvent_GetWaitList function #510

Merged

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR adds the 'DPCTLEvent_GetWaitList' function which returns the list of events that this event waits for in the dependence graph.

@coveralls
Copy link
Collaborator

coveralls commented Jul 15, 2021

Coverage Status

Coverage decreased (-0.1%) to 65.046% when pulling b5374bb on vlad-perevezentsev:event_getwaitlist into 893f1f6 on IntelPython:master.

@vlad-perevezentsev
Copy link
Collaborator Author

@oleksandr-pavlyk I added a Sycl test for function.
It works on SYCL but test fails with DPCTLSyclEvent.

/localdisk/work/vperevez/dp_dparray/dpctl_vlad/dpctl/dpctl-capi/tests/test_sycl_event_interface.cpp:158: Failure
Value of: DPCTLEventVector_Size(EVRef) > 0
  Actual: false
Expected: true

Dependencies passed via ' sycl:: handler::depends_on` are not included in the graph, but are tracked (Compiler LLVM team).
This is a bug. https://jira.devtools.intel.com/browse/CMPLRLLVM-30013

@vlad-perevezentsev vlad-perevezentsev force-pushed the event_getwaitlist branch 3 times, most recently from 97e11c4 to b433ce7 Compare August 4, 2021 11:36
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied the requested changes and resolved conflicts from earlier merges

@oleksandr-pavlyk oleksandr-pavlyk merged commit e5c50ea into IntelPython:master Aug 9, 2021
@vlad-perevezentsev vlad-perevezentsev deleted the event_getwaitlist branch June 20, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants