Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda build scripts should build wheels in the same setup invocation … #538

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

…as install

Using

python setup.py cmd1 opts1 cmd2 opts ...

Copy link
Contributor

@AndresGuzman-Ballen AndresGuzman-Ballen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M!

@coveralls
Copy link
Collaborator

coveralls commented Aug 19, 2021

Coverage Status

Coverage remained the same at 65.067% when pulling 517c41f on infra/improve-build-wheels into a6a54d3 on master.

…as install

Using

```
python setup.py cmd1 opts1 cmd2 opts ...
```
@oleksandr-pavlyk
Copy link
Collaborator Author

Linux CI builds passed, windows CI were hanging. Checking locally revealed issues caused by quoting at the wrong place.

Once fixed, both wheel-output and regular install steps succeeded fine.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 73440ac into master Aug 20, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the infra/improve-build-wheels branch August 20, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants