Feature/cython public api #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use api keyword in declaring API functions. Use of API defines initializer functions which allows native extensions that work with dpctl Python types to not link to Python-produced shared objects on Linux, and allows for pybind11 to portably work with Python types defined in dpctl. Example for working with dpctl types is to be added to dpctl/examples
oleksandr-pavlyk
requested review from
diptorupd,
reazulhoque,
Alexander-Makaryev and
vlad-perevezentsev
oleksandr-pavlyk
added a commit
to 1e-to/dpctl
that referenced
this pull request
Aug 25, 2021
Added reference to work in pull request IntelPython#550
oleksandr-pavlyk
added a commit
that referenced
this pull request
Aug 25, 2021
* Update CHANGELOG * Update CHANGELOG.md Expanded fixes in 0.9.0 * Update CHANGELOG.md Added reference to work in pull request #550 Co-authored-by: Oleksandr Pavlyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved generation of C-API for Cython native extension classes and functions that operate on them.
This is accomplished by using
public apifor classes, and use ifapiqualifier for functions.An example of pybind11 extension was added to demonstrate use of
dpctlPython types generated by Cython in native extensions other than Cython.