Static method SyclQueue._create_from_context_and_device change #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added docstrings 2. Added optional keyword argument props, to allow queue creation with properties. This method is not covered in test suite. To solve this, test suite needs to learn to build and use Cython extensions
oleksandr-pavlyk
force-pushed
the
fix-SyclQueue-create-from-context-and-device
branch
from
c975c70 to
e4281aa
Compare
…st Cython API functions The extension is built in temp folder. Added cython as Cython test dependency Pass --cov-config option to pytest with coverage. This works around coverage config discrepancy between the main process and a subprocess. See pytest-dev/pytest-cov#243 added _cython_api.pyx to flake exception list Exclude dpctl/tests/* and dpctl/_version from coverage reporting Fix loading of Cython extension _cython_api on Windows Add test for property=int usage
oleksandr-pavlyk
force-pushed
the
fix-SyclQueue-create-from-context-and-device
branch
from
e4281aa to
97c9702
Compare
|
The PR is now ready for review, and can be merged. |
oleksandr-pavlyk
deleted the
fix-SyclQueue-create-from-context-and-device
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with properties.
dpctl/tests/*and not to report it. Thus, this PR closes Coverage does not skip tests folder #374test_sycl_queuenow adds a test that build a cython extension and calls Cython API functions, e.g. static methods of classes.