Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid passing nullptr to sycl::queue::prefetch to avoid buggy hang #612

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

For bookkeeping filed an issue behind the hang as XDEPS-2765.

Fix for the hang is to avoid passing nullptr argument to sycl::queue::prefetch.

@oleksandr-pavlyk
Copy link
Collaborator Author

Very likely this hang was the reason why the Generate coverage data workflow never got to building the Python extensions.

@oleksandr-pavlyk
Copy link
Collaborator Author

Very likely this hang was the reason why the Generate coverage data workflow never got to building the Python extensions.

No the failure is due to a problem with genhtml:

2021-09-30T18:48:05.7792522Z genhtml: ERROR: cannot read /tmp/test_service-c3cfab.cpp
2021-09-30T18:48:05.7793677Z make[3]: *** [tests/CMakeFiles/lcov-genhtml.dir/build.make:72: tests/CMakeFiles/lcov-genhtml] Error 2
2021-09-30T18:48:05.7794817Z make[2]: *** [CMakeFiles/Makefile2:207: tests/CMakeFiles/lcov-genhtml.dir/all] Error 2
2021-09-30T18:48:05.7795883Z make[1]: *** [CMakeFiles/Makefile2:214: tests/CMakeFiles/lcov-genhtml.dir/rule] Error 2
2021-09-30T18:48:05.7796749Z make: *** [Makefile:221: lcov-genhtml] Error 2

On the next line of the workflow, we are executing import of dpctl, which fails

2021-09-30T18:48:05.7817325Z ModuleNotFoundError: No module named 'dpctl._sycl_context'

but this goes unnoticed, and the worflow script proceeds with running pytest.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 6cf9b2f into master Sep 30, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-prefetch-hang branch September 30, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant