-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use readelf on pi_level_zero library to find exact name of ze_loader #617
Conversation
dpctl-capi/CMakeLists.txt
Outdated
find_program(READELF_PROG readelf) | ||
find_program(GREP_PROG grep) | ||
execute_process( | ||
COMMAND ${READELF_PROG} -d ${PI_LEVEL_ZERO_LIB} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation is off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this done. Except for the minor indentation issues that need to be addressed, the PR is good to go.
730e0f6
to
78e85c9
Compare
Store that in include/Config/dpctl_config.h and use the define in dpctl_sycl_program_interface.cpp CMake is running the equivalent of the following ``` readelf -d $DPCPP_ROOT/lib/libpi_level_zero.so | grep libze_loader | grep -Po "libze_loader[^\]]*" libze_loader.so.1 ```
78e85c9
to
55a532e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Store that in include/Config/dpctl_config.h and use the define in
dpctl_sycl_program_interface.cpp
CMake is running the equivalent of the following
This change, together with #603 and #616 make project buildable with OS compiler.