Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opencl interoprability code to fix build with open source llvm/sycl bundle #625

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Closes #624

Replaced sycl::context::get() with
sycl::context::get_native<sycl::backend::opencl>().

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-opencl-interop branch 2 times, most recently from 4cd923c to 5574bc3 Compare October 12, 2021 13:31
@coveralls
Copy link
Collaborator

coveralls commented Oct 12, 2021

Coverage Status

Coverage remained the same at 74.419% when pulling 67afcec on fix-opencl-interop into da90ebd on master.

Replaced sycl::context::get() with
sycl::get_native<sycl::backend::opencl>( context )

Similar change for level-zero.
@diptorupd
Copy link
Contributor

Is the internal CI failures due to DPC++ version incompatibility?

@oleksandr-pavlyk
Copy link
Collaborator Author

Is the internal CI failures due to DPC++ version incompatibility?

Seems to be an internal infra script problem:

  Traceback (most recent call last):
09:40:09
  Test deps                = ['pytest-cov', 'cython', 'pytest', 'teamcity-messages']
09:40:09
    File "teamcity-integration/src/pypi/testing.py", line 81, in <module>
09:40:09
  Path to smoke tests      = None
09:40:09
      add_library_path=apply_workaround)
09:40:09
  Path to functional tests = /localdisk/tools/tc/agent1/work/4f533563c9f3b284/dpctl/run_test.sh
09:40:09
    File "/localdisk/tools/tc/agent1/work/4f533563c9f3b284/teamcity-integration/src/pypi/tools.py", line 160, in setup_pypi_environment
09:40:09
  Setup pypi_test venv environment for python 3.8
09:40:09
      raise Exception('\n'.join(output))
09:40:09
  conda remove -q -y --name pypi_test --all
09:40:09
  conda create -q -y -n pypi_test python=3.8 pip -c anaconda --override-channels
09:40:09
  Exception: source /localdisk/tools/tc/agent1/work/4f533563c9f3b284/base/etc/profile.d/conda.sh && conda activate pypi_test && python -m venv /localdisk/tools/tc/agent1/work/4f533563c9f3b284/pypi_test_venv --clear
09:40:09
  -------------------------------------------------------------------------------
09:40:09
  /bin/sh: 1: source: not found
09:40:09
  source /localdisk/tools/tc/agent1/work/4f533563c9f3b284/base/etc/profile.d/conda.sh && conda activate pypi_test && python -m venv /localdisk/tools/tc/agent1/work/4f533563c9f3b284/pypi_test_venv --clear
09:40:09
  -   -   -   -   -   -   -   -   -   -   -   -   -   -   -   -   -   -   -   -
09:40:09
  /bin/sh: 1: source: not found
09:40:09
  Process exited with code 1
09:40:09
  Process exited with code 1 (Step: testing with local perflibs (Command Line))

@oleksandr-pavlyk oleksandr-pavlyk enabled auto-merge (squash) October 12, 2021 16:07
@oleksandr-pavlyk oleksandr-pavlyk merged commit 2907977 into master Oct 12, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-opencl-interop branch October 12, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS llvm sycl build breaks because of removed method sycl::device::get
3 participants